Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.

View Change

3 comments:

• File include/libflashrom.h:

  • Patch Set #7, Line 112: */

    The comment should probably have a note saying that this has priority over `flashrom_set_progress_ca […]

    Done

• File libflashrom.c:

  • Patch Set #7, Line 76: " ignoring this call since %s is deprecated\n",

    nit: there is already a space on the previous line

    Done

  • Patch Set #7, Line 134: sizeof(flashctx->progress_state.user_data));

    nit: Why use `memcpy()`? Types match, so simple assignments should do and will break if types chang […]

    user_data was complaining on dereferencing void pointer so I changed to `memcpy()` and then I changed progress_state copying to memcpy so that they look the same.

    For progress_state it wasn't needed, I changed it back to be an assignment.

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.