Change in flashrom[master]: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62868 )

Change subject: ichspi: Introduce HSFC CYCLE READ/WRITE/ERASE macros
......................................................................

Patch Set 12:

(1 comment)

File ichspi.c:

https://review.coreboot.org/c/flashrom/+/62868/comment/f9b6a577_d70135db 
PS12, Line 163: #define HSFC_FCYCLE(cyc)	((cyc) << HSFC_FCYCLE_OFF)
> > Isn't this equivalent to `HSFC_FCYCLE_MASK`? […]

Yes, I agree that HSFC_FCYCLE_MASK(n) and HSFC_FCYCLE(n) both unfold into the same expression: (n << HSFC_FCYCLE_OFF).

Maybe... would it work to remove line 163 `#define HSFC_FCYCLE(cyc)` and for lines 164-166 use existing macro:

#define HSFC_CYCLE_READ		HSFC_FCYCLE_MASK(0)
#define HSFC_CYCLE_WRITE	HSFC_FCYCLE_MASK(2)
#define HSFC_CYCLE_4K_ERASE	HSFC_FCYCLE_MASK(3)

?