Attention is currently required from: Subrata Banik, Edward O'Callaghan, Angel Pons.

View Change

1 comment:

• File ichspi.c:

  • Patch Set #12, Line 163: #define HSFC_FCYCLE(cyc) ((cyc) << HSFC_FCYCLE_OFF)

    > Isn't this equivalent to `HSFC_FCYCLE_MASK`? […]

    Yes, I agree that HSFC_FCYCLE_MASK(n) and HSFC_FCYCLE(n) both unfold into the same expression: (n << HSFC_FCYCLE_OFF).

    Maybe... would it work to remove line 163 `#define HSFC_FCYCLE(cyc)` and for lines 164-166 use existing macro:

    #define HSFC_CYCLE_READ HSFC_FCYCLE_MASK(0)
    #define HSFC_CYCLE_WRITE HSFC_FCYCLE_MASK(2)
    #define HSFC_CYCLE_4K_ERASE HSFC_FCYCLE_MASK(3)

    ?

To view, visit change 62868. To unsubscribe, or for help writing mail filters, visit settings.