Attention is currently required from: DZ, Dolan Liu, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Dolan Liu. ( https://review.coreboot.org/c/flashrom/+/86348?usp=email )
Change subject: flashchips: Add Macronix MX77U25650FZ4I42
......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2:
Hi Anastasia, I have compared this with RPMC datasheet, all the flashchip definition is correct.
Thank you so much for your help
PS2:
Hello Dolan, just wanted to say - the last two comments are for you to do :) It's two small things.
After you do those, you will upload new patchset and this will trigger Jenkins re-run, which will give you verified +1.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/86348?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7866b2db343f4eb2bc194400ceca099d3af3b87d
Gerrit-Change-Number: 86348
Gerrit-PatchSet: 2
Gerrit-Owner: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: DZ
danielzhang@mxic.com.cn
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: DZ
danielzhang@mxic.com.cn
Gerrit-Attention: Dolan Liu
liuyong5@huaqin.corp-partner.google.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Tue, 25 Mar 2025 06:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: DZ
danielzhang@mxic.com.cn
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org