Attention is currently required from: DZ, Dolan Liu, Nikolai Artemiev, Stefan Reinauer.
View Change
2 comments:
Patchset:
Patch Set #2:
Hi Anastasia, I have compared this with RPMC datasheet, all the flashchip definition is correct.
Thank you so much for your help
Patch Set #2:
Hello Dolan, just wanted to say - the last two comments are for you to do :) It's two small things.
After you do those, you will upload new patchset and this will trigger Jenkins re-run, which will give you verified +1.
To view, visit change 86348. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7866b2db343f4eb2bc194400ceca099d3af3b87d
Gerrit-Change-Number: 86348
Gerrit-PatchSet: 2
Gerrit-Owner: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: DZ <danielzhang@mxic.com.cn>
Gerrit-Reviewer: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Reviewer: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: DZ <danielzhang@mxic.com.cn>
Gerrit-Attention: Dolan Liu <liuyong5@huaqin.corp-partner.google.com>
Gerrit-Attention: Stefan Reinauer <stefan.reinauer@coreboot.org>
Gerrit-Attention: Nikolai Artemiev <nartemiev@google.com>
Gerrit-Comment-Date: Tue, 25 Mar 2025 06:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: DZ <danielzhang@mxic.com.cn>
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>