Attention is currently required from: Angel Pons. Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51967 )
Change subject: lspcon_i2c_spi: support a devpath option ......................................................................
Patch Set 2:
(4 comments)
File i2c_helper_linux.c:
https://review.coreboot.org/c/flashrom/+/51967/comment/f3f869b9_d6696f3e PS1, Line 46: goto err;
`goto` isn't necessary here, just return `fd`.
Done
https://review.coreboot.org/c/flashrom/+/51967/comment/bd0b9247_22fa4da3 PS1, Line 54: goto err;
Same here, just return `err`.
Done
https://review.coreboot.org/c/flashrom/+/51967/comment/ea7c850c_6bde3ec2 PS1, Line 58: return ret ? ret : fd;
And return `fd` here.
Done
File lspcon_i2c_spi.c:
https://review.coreboot.org/c/flashrom/+/51967/comment/0b3378f0_060292fc PS1, Line 486: msg_perr("%s: one of devpath or bus must be specified\n", __func__);
If both arguments are specified, `bus` is silently ignored. […]
Revised further so invalid bus values are distinct from unspecified, allowing the two options to be mutually exclusive.
-
Peter Marheine (Code Review)