Attention is currently required from: Angel Pons.

View Change

4 comments:

• File i2c_helper_linux.c:

  • Patch Set #1, Line 46: goto err;

    `goto` isn't necessary here, just return `fd`.

    Done

  • Patch Set #1, Line 54: goto err;

    Same here, just return `err`.

    Done

  • Patch Set #1, Line 58: return ret ? ret : fd;

    And return `fd` here.

    Done

• File lspcon_i2c_spi.c:

  • Patch Set #1, Line 486: msg_perr("%s: one of devpath or bus must be specified\n", __func__);

    If both arguments are specified, `bus` is silently ignored. […]

    Revised further so invalid bus values are distinct from unspecified, allowing the two options to be mutually exclusive.

To view, visit change 51967. To unsubscribe, or for help writing mail filters, visit settings.