Attention is currently required from: Miklós Márton, Peter Marheine, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75236?usp=email )
Change subject: meson: Add support for ni845x_spi on Windows ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/75236/comment/661b91c8_865c4261 : PS6, Line 12: choise Oh I found typo: choise -> choice
Patchset:
PS4:
I rebased this branch on top of master (currently b09aad573) and it built successfully for me. […]
Miklos, does this work for you? I see you approved documentation patch (next one in the chain), does it mean it builds for you successfully?
PS4:
Need testing: what if the include path is not available under windows? will it just ignore the non e […]
Thomas, do you plan any more testing? Which include path do you mean, is that the one hardcoded in meson options, `C:\Program Files (x86)\National Instruments\Ni-845x\MS Visual C` ?
-
Anastasia Klimchuk (Code Review)