Attention is currently required from: Miklós Márton, Peter Marheine, Thomas Heijligen.
Patch set 6:Code-Review +1
View Change
3 comments:
Commit Message:
Patchset:
Patch Set #4:
I rebased this branch on top of master (currently b09aad573) and it built successfully for me. […]
Miklos, does this work for you?
I see you approved documentation patch (next one in the chain), does it mean it builds for you successfully?
Patch Set #4:
Need testing: what if the include path is not available under windows? will it just ignore the non e […]
Thomas, do you plan any more testing? Which include path do you mean, is that the one hardcoded in meson options, `C:\Program Files (x86)\National Instruments\Ni-845x\MS Visual C` ?
To view, visit change 75236. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2d32f11852ac1a5184af8e8683ca1914a6e72973
Gerrit-Change-Number: 75236
Gerrit-PatchSet: 6
Gerrit-Owner: Thomas Heijligen <src@posteo.de>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Miklós Márton <martonmiklosqdev@gmail.com>
Gerrit-Attention: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Peter Marheine <pmarheine@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jun 2023 08:11:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Miklós Márton <martonmiklosqdev@gmail.com>
Comment-In-Reply-To: Thomas Heijligen <src@posteo.de>
Comment-In-Reply-To: Peter Marheine <pmarheine@chromium.org>
Gerrit-MessageType: comment