Attention is currently required from: Light, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/63130 )
Change subject: pony_spi.c: Extract out get_params to simplify init ......................................................................
Patch Set 3:
(2 comments)
File pony_spi.c:
https://review.coreboot.org/c/flashrom/+/63130/comment/5b87a07d_423b23d9 PS3, Line 167: bool have_device;
This should probably be a separate patch? (changing variable type int -> bool)
A bit of nit isn't it? Is there a solid technical reason here or just personal preference?
https://review.coreboot.org/c/flashrom/+/63130/comment/079204ec_66a5c753 PS3, Line 190: serialport_shutdown
This one line should probably also go to a very useful separate patch.
I think you are mis-interpreting the diff presented by gerrit Anastasia.
-
Edward O'Callaghan (Code Review)