Attention is currently required from: Light, Anastasia Klimchuk.

View Change

2 comments:

• File pony_spi.c:

  • Patch Set #3, Line 167: bool have_device;

    This should probably be a separate patch? (changing variable type int -> bool)

    A bit of nit isn't it? Is there a solid technical reason here or just personal preference?

  • Patch Set #3, Line 190: serialport_shutdown

    This one line should probably also go to a very useful separate patch.

    I think you are mis-interpreting the diff presented by gerrit Anastasia.

To view, visit change 63130. To unsubscribe, or for help writing mail filters, visit settings.