[S] Change in flashrom[main]: ichspi: Restore Sector erase opcode after send command - flashrom-gerrit

30 Sep 2024


      Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Peter Marheine.
Bill XIE has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84253?usp=email )
Change subject: ichspi: Restore Sector erase opcode after send command
......................................................................
Patch Set 1:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/84253/comment/c9fb1e05_31547cef?usp... :
PS1, Line 2078: reg
However, is it okay to just use spi_master_ich9 here? (maybe after renaming it to "spi_master_ich79" or something, identical to use ich_spi_probe_opcode() for .probe_opcode() for ich7 as well)
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/84253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3fc831fc072e2af9265835cb2f71bf8c222c6a64
Gerrit-Change-Number: 84253
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE persmule@hardenedlinux.org
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Attention: Peter Marheine pmarheine@chromium.org
Gerrit-Comment-Date: Mon, 30 Sep 2024 06:58:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No