[S] Change in flashrom[main]: ichspi: Restore Sector erase opcode after send command

[Bill XIE (Code Review)]

Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Peter Marheine.

Bill XIE has posted comments on this change by Bill XIE. ( https://review.coreboot.org/c/flashrom/+/84253?usp=email )

Change subject: ichspi: Restore Sector erase opcode after send command
......................................................................


Patch Set 1:

(1 comment)

File ichspi.c:

https://review.coreboot.org/c/flashrom/+/84253/comment/6ddd8e0f_f7111307?usp... :
PS1, Line 1843: 
              : static bool ich_spi_probe_opcode(const struct flashctx *flash, uint8_t opcode)
              : {
              : 	return find_opcode(curopcodes, opcode) >= 0;
> That way, ich_spi_send_command will automatically reprogram the required opcode if it is missing and we don't have to restore JEDEC_SE after every command that reprograms it.

I have once considered this, but the issue is that spi_master_ich7 does use ich_spi_send_(multi)command() but does not implement .probe_opcode().
> Bill, would you agree to change your patch, and test the different solution?
> As a plan B I can upload new version of the patch, but asking you first because you are the author (and you did all the debugging).
> Also, in any case, original author of the patch stays (even if someone uploads new version)

If you have a better solution, you are free to replace mine.



-- 
To view, visit https://review.coreboot.org/c/flashrom/+/84253?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3fc831fc072e2af9265835cb2f71bf8c222c6a64
Gerrit-Change-Number: 84253
Gerrit-PatchSet: 1
Gerrit-Owner: Bill XIE <[e-mail]>
Gerrit-Reviewer: Anastasia Klimchuk <[e-mail]>
Gerrit-Reviewer: Nikolai Artemiev <[e-mail]>
Gerrit-Reviewer: Peter Marheine <[e-mail]>
Gerrit-Reviewer: build bot (Jenkins) <[e-mail]>
Gerrit-Attention: Anastasia Klimchuk <[e-mail]>
Gerrit-Attention: Nikolai Artemiev <[e-mail]>
Gerrit-Attention: Peter Marheine <[e-mail]>
Gerrit-Comment-Date: Mon, 30 Sep 2024 06:49:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <[e-mail]>
Comment-In-Reply-To: Nikolai Artemiev <[e-mail]>