Attention is currently required from: Anastasia Klimchuk, Richard Hughes.
Sergii Dmytruk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )
Change subject: libflashrom: Update the API for progress callback ......................................................................
Patch Set 2:
(3 comments)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86031/comment/fb624ba7_052a4062?usp... : PS2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead Deprecation is when the thing remains accessible, but I don't see implementation of `flashrom_set_progress_callback()` anywhere. Did you forget to do it? The symbol in the `.map` file suggests this.
https://review.coreboot.org/c/flashrom/+/86031/comment/965b80e4_f0ffba5a?usp... : PS2, Line 101: void* user_data); nit: the changes have inconsistent formatting of pointers (space is either before or after an asterisk).
https://review.coreboot.org/c/flashrom/+/86031/comment/995e07df_f71aa666?usp... : PS2, Line 113: void flashrom_set_progress_callback_v1(struct flashrom_flashctx *const flashctx, Isn't this `v2`? E.g., Linux has `openat()` and `openat2()` syscalls.