Attention is currently required from: Anastasia Klimchuk, Richard Hughes.

View Change

3 comments:

• File include/libflashrom.h:

  • Patch Set #2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead

    Deprecation is when the thing remains accessible, but I don't see implementation of `flashrom_set_progress_callback()` anywhere. Did you forget to do it? The symbol in the `.map` file suggests this.

  • Patch Set #2, Line 101: void* user_data);

    nit: the changes have inconsistent formatting of pointers (space is either before or after an asterisk).

  • Patch Set #2, Line 113: void flashrom_set_progress_callback_v1(struct flashrom_flashctx *const flashctx,

    Isn't this `v2`? E.g., Linux has `openat()` and `openat2()` syscalls.

To view, visit change 86031. To unsubscribe, or for help writing mail filters, visit settings.