Attention is currently required from: Paul Menzel, Angel Pons, Light. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62725 )
Change subject: libflashrom.c: Fix unintialized value passed to function ......................................................................
Patch Set 7: Code-Review+2
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62725/comment/bfdc40d5_741005ae PS1, Line 7: fixed
Fix
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/54413eda_7495a33f PS1, Line 9: y
t
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/54b944ce_a9d554d5 PS1, Line 9: In function flash_layouy_read_from_ifd variable chip_layout remains uninitialized if prepare_flash_access returns
Please wrap commit message lines at 72 characters, c.f. https://flashrom. […]
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/206c968f_98897b36 PS1, Line 10: flase
typo: false
Done
https://review.coreboot.org/c/flashrom/+/62725/comment/8c8872ea_e8a03f3d PS1, Line 10: unintialzed
2 typos: uninitialized
Done
Patchset:
PS7: Hi Aarya, nice patch!
There's one tiny typo left in the commit message I think.
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/62725/comment/eabe3039_b4e23023 PS1, Line 445: struct flashrom_layout *dump_layout=0, *chip_layout=0;
Since these are pointers, I'd use NULL. […]
Done
-
Nico Huber (Code Review)