Attention is currently required from: Paul Menzel, Angel Pons, Light.
Patch set 7:Code-Review +2
7 comments:
Commit Message:
Patch Set #1, Line 7: fixed
Fix
Done
t
Done
Patch Set #1, Line 9: In function flash_layouy_read_from_ifd variable chip_layout remains uninitialized if prepare_flash_access returns
Please wrap commit message lines at 72 characters, c.f. https://flashrom. […]
Done
Patch Set #1, Line 10: flase
typo: false
Done
Patch Set #1, Line 10: unintialzed
2 typos: uninitialized
Done
Patchset:
Hi Aarya, nice patch!
There's one tiny typo left in the commit message I think.
File libflashrom.c:
Patch Set #1, Line 445: struct flashrom_layout *dump_layout=0, *chip_layout=0;
Since these are pointers, I'd use NULL. […]
Done
To view, visit change 62725. To unsubscribe, or for help writing mail filters, visit settings.