David Hendricks has posted comments on this change. ( https://review.coreboot.org/23021 )
Change subject: layout: Add -i <region>[:<file>] support. ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/#/c/23021/7/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/23021/7/flashrom.c@2647 PS7, Line 2647: if (read_buf_from_file(newcontents, flash_size, filename, "the flash chip's size"))
Looking back, this seems to have been messed up in translation. My fault. […]
Fixed in subsequent patch sets by removing the else and reading files from '-i' args if specified.
https://review.coreboot.org/#/c/23021/11/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/23021/11/flashrom.c@2683 PS11, Line 2683: get_num_include_args_with_files(get_layout I needed to add this to avoid 'Error: No image file given for region ...' in read_buf_from_include_args().
-
David Hendricks (Code Review)