View Change
2 comments:
File flashrom.c:
Patch Set #7, Line 2647: if (read_buf_from_file(newcontents, flash_size, filename, "the flash chip's size"))
Looking back, this seems to have been messed up in translation. My fault. […]
Fixed in subsequent patch sets by removing the else and reading files from '-i' args if specified.
File flashrom.c:
Patch Set #11, Line 2683: get_num_include_args_with_files(get_layout
I needed to add this to avoid 'Error: No image file given for region ...' in read_buf_from_include_args().
To view, visit change 23021. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic5465659605d8431d931053967b40290195cfd99
Gerrit-Change-Number: 23021
Gerrit-PatchSet: 11
Gerrit-Owner: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Reviewer: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Gerrit-Reviewer: David Hendricks <david.hendricks@gmail.com>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Nicola Corna <nicola@corna.info>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 21 Jan 2018 02:51:16 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No