[M] Change in flashrom[master]: tests: Add llvm-cov option and run target for code coverage
Attention is currently required from: Thomas Heijligen, Evan Benn.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69268 )
Change subject: tests: Add llvm-cov option and run target for code coverage ......................................................................
Patch Set 15: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69268/comment/7886a47a_381bbaaa PS11, Line 14: TEST=meson test; ninja llvm-cov-tests
yes I also ran without coverage (and so does jenkins! V+1)
Great! Then the last thing left: add this to TEST= in commit message :)
File meson.build:
https://review.coreboot.org/c/flashrom/+/69268/comment/d11d7e89_ae9d9579 PS14, Line 625: run_target('llvm-cov-cli', command : ['scripts/llvm-cov', classic_cli])
This is declaring a run target, its not running anything. […]
Oh I see. I agree looks better (less confusing) inside the if
-
Anastasia Klimchuk (Code Review)