Attention is currently required from: Thomas Heijligen, Evan Benn.

Patch set 15:Code-Review +1

View Change

2 comments:

• Commit Message:

  • Patch Set #11, Line 14: TEST=meson test; ninja llvm-cov-tests

    yes I also ran without coverage (and so does jenkins! V+1)

    Great! Then the last thing left: add this to TEST= in commit message :)

• File meson.build:

  • Patch Set #14, Line 625: run_target('llvm-cov-cli', command : ['scripts/llvm-cov', classic_cli])

    This is declaring a run target, its not running anything. […]

    Oh I see. I agree looks better (less confusing) inside the if

To view, visit change 69268. To unsubscribe, or for help writing mail filters, visit settings.