Attention is currently required from: Anastasia Klimchuk, Fabian Groffen.
Peter Marheine has posted comments on this change by Fabian Groffen. ( https://review.coreboot.org/c/flashrom/+/83262?usp=email )
Change subject: dummyflasher: assign address of function for LLVM ......................................................................
Patch Set 1:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/83262/comment/46a93416_bbbd9702?usp... : PS1, Line 972: &
Why this is not needed for all other function pointers? (I feel like I am missing something. […]
I agree this is odd; I'm not able to reproduce using Clang 16 in what looks like it should be a minimal reproducer: https://godbolt.org/z/Tcbd4bvz9
It's possible there's a detail I'm not capturing, or the compiler raising this is broken somehow.
-
Peter Marheine (Code Review)