Attention is currently required from: Anastasia Klimchuk, Fabian Groffen.
View Change
1 comment:
File dummyflasher.c:
Patch Set #1, Line 972: &
Why this is not needed for all other function pointers? (I feel like I am missing something. […]
I agree this is odd; I'm not able to reproduce using Clang 16 in what looks like it should be a minimal reproducer: https://godbolt.org/z/Tcbd4bvz9
It's possible there's a detail I'm not capturing, or the compiler raising this is broken somehow.
To view, visit change 83262. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I8e5c9ea014d40a2e9e0621b25f8c404e80a79952
Gerrit-Change-Number: 83262
Gerrit-PatchSet: 1
Gerrit-Owner: Fabian Groffen <grobian@gentoo.org>
Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Reviewer: Peter Marheine <pmarheine@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-Attention: Fabian Groffen <grobian@gentoo.org>
Gerrit-Comment-Date: Tue, 02 Jul 2024 04:38:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org>