Change in flashrom[master]: spi25.c: Add a null check

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/39974 )

Change subject: spi25.c: Add a null check
......................................................................

spi25.c: Add a null check

Change-Id: I5fcc23d81b8404af90768afa2954509bf334ab2c
Signed-off-by: Angel Pons 
---
M spi25.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/74/39974/1

diff --git a/spi25.c b/spi25.c
index 2a1d492..0a939e7 100644
--- a/spi25.c
+++ b/spi25.c
@@ -427,6 +427,8 @@
    	msg_cerr("%s called for too long a write\n", __func__);
    	return 1;
    }
+	if (!out_bytes && out_len > 0)
+		return 1;

memcpy(cmd + 1 + addr_len, out_bytes, out_len);
    cmds[1].writecnt = 1 + addr_len + out_len;

[HAOUAS Elyes (Code Review)]

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39974 )

Change subject: spi25.c: Add a null check
......................................................................

Patch Set 3: Code-Review+2

[Edward O'Callaghan (Code Review)]

Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/39974 )

Change subject: spi25.c: Add a null check
......................................................................

Patch Set 3: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/39974 )

Change subject: spi25.c: Add a null check
......................................................................

spi25.c: Add a null check

Change-Id: I5fcc23d81b8404af90768afa2954509bf334ab2c
Signed-off-by: Angel Pons 
Reviewed-on: https://review.coreboot.org/c/flashrom/+/39974
Reviewed-by: HAOUAS Elyes 
Reviewed-by: Edward O'Callaghan 
Tested-by: build bot (Jenkins) 
---
M spi25.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  HAOUAS Elyes: Looks good to me, approved
  Edward O'Callaghan: Looks good to me, approved

diff --git a/spi25.c b/spi25.c
index c774f99..16d7f1b 100644
--- a/spi25.c
+++ b/spi25.c
@@ -570,6 +570,8 @@
    	msg_cerr("%s called for too long a write\n", __func__);
    	return 1;
    }
+	if (!out_bytes && out_len > 0)
+		return 1;

memcpy(cmd + 1 + addr_len, out_bytes, out_len);
    cmds[1].writecnt = 1 + addr_len + out_len;