Angel Pons submitted this change.

View Change

spi25.c: Add a null check

Change-Id: I5fcc23d81b8404af90768afa2954509bf334ab2c
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/39974
Reviewed-by: HAOUAS Elyes <ehaouas@noos.fr>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M spi25.c
1 file changed, 2 insertions(+), 0 deletions(-)

diff --git a/spi25.c b/spi25.c
index c774f99..16d7f1b 100644
--- a/spi25.c
+++ b/spi25.c
@@ -570,6 +570,8 @@
 		msg_cerr("%s called for too long a write\n", __func__);
 		return 1;
 	}
+	if (!out_bytes && out_len > 0)
+		return 1;
 
 	memcpy(cmd + 1 + addr_len, out_bytes, out_len);
 	cmds[1].writecnt = 1 + addr_len + out_len;

To view, visit change 39974. To unsubscribe, or for help writing mail filters, visit settings.