Attention is currently required from: Edward O'Callaghan. Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49632 )
Change subject: ft2232_spi.c: release I/Os on shutdown ......................................................................
Patch Set 2:
(2 comments)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/49632/comment/2b671720_11610e25 PS1, Line 175: ret = -8; : goto ftdi_err; : } : : ftdi_err:
I feel like this goto makes things more complex then it needs to be for a single branch, the ret of […]
Good call. I had copy-paste from elsewhere, which left a bit of a mess.
https://review.coreboot.org/c/flashrom/+/49632/comment/008388e7_7389de67 PS1, Line 183: return f;
ret = f; would be consistent with the rest of the control flow.
I think this makes more sense now.