Attention is currently required from: Edward O'Callaghan.

View Change

2 comments:

• File ft2232_spi.c:

  • Patch Set #1, Line 175:

    	ret = -8;
    		goto ftdi_err;
    	}
    
    ftdi_err:
    

    I feel like this goto makes things more complex then it needs to be for a single branch, the ret of […]

    Good call. I had copy-paste from elsewhere, which left a bit of a mess.

  • Patch Set #1, Line 183: return f;

    ret = f; would be consistent with the rest of the control flow.

    I think this makes more sense now.

To view, visit change 49632. To unsubscribe, or for help writing mail filters, visit settings.