Attention is currently required from: Nico Huber, Edward O'Callaghan, Samir Ibradžić. Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Implement spi_send_multicommand() ......................................................................
Patch Set 31:
(4 comments)
Patchset:
PS31: I made some tests with my oscilloscope on the SPI lines. Looks good to me. E.g. the WREN is send in one burst with the page program data. As chunksize of 270 was set to make page program in one burst but without having WREN in mind the chunksize must be adapted to really benefit of this change. Fot this see review.coreboot.org/c/flashrom/+/43282
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/comment/060915f0_2608122c PS30, Line 291: <= buffer_size;
Sorry, looks like you copy-pasted from my comment? Needs tabs.
Done
Yes I did, sorry for forgetting the tabs and all the other indent stuff.
https://review.coreboot.org/c/flashrom/+/40477/comment/0206c0a3_8fd8dc6a PS30, Line 303: * Minimize FTDI-calls by packing as many commands as possible
Nit, the line break just seems odd.
Done
https://review.coreboot.org/c/flashrom/+/40477/comment/c74d3031_148a343f PS30, Line 311: ){
Missing space before opening brace.
Done
-
Simon Buhrow (Code Review)