Attention is currently required from: Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71623 )
Change subject: board_enables: Couple prog cfg with board cfg ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1: It's hard to say if all the plumbing is needed, but no idea how to make it better.
File internal.c:
https://review.coreboot.org/c/flashrom/+/71623/comment/e1b8040f_e61d8481 PS1, Line 270: board_handle_before_superio((struct programmer_cfg *)cfg); Ugh, it'd be better to avoid casting away const... Quick solution would be to make a mutable local copy:
struct programmer_cfg mut_cfg = *cfg;
Then use `&mut_cfg` as argument instead of `(struct programmer_cfg *)cfg`.