Attention is currently required from: Edward O'Callaghan.

View Change

2 comments:

• Patchset:

  • Patch Set #1:

    It's hard to say if all the plumbing is needed, but no idea how to make it better.

• File internal.c:

  • Patch Set #1, Line 270: board_handle_before_superio((struct programmer_cfg *)cfg);

    Ugh, it'd be better to avoid casting away const... Quick solution would be to make a mutable local copy:

     struct programmer_cfg mut_cfg = *cfg;

    Then use `&mut_cfg` as argument instead of `(struct programmer_cfg *)cfg`.

To view, visit change 71623. To unsubscribe, or for help writing mail filters, visit settings.