Attention is currently required from: Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52596 )
Change subject: mec1308.c: Untangle successful vs failed init paths
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
File mec1308.c:
https://review.coreboot.org/c/flashrom/+/52596/comment/9ad938d2_50d13057
PS1, Line 519: mec1308_init_exit
I would probably rename it, e.g. `mec1308_init_err`. It's not "the" exit anymore. Could be done in the follow up, too.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52596
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibf35335501e59636c544af124ad7a04a186790b4
Gerrit-Change-Number: 52596
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-CC: Victor Ding
victording@google.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 23 Apr 2021 14:57:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment