Attention is currently required from: Anastasia Klimchuk. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52595 )
Change subject: mec1308.c: Extract params check into a function ......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52595/comment/7bc037d5_ba374fc0 PS1, Line 9: This allows char *p to become a local variable in
done (and also for other patches in this chain).
It's literally a limit, though. There is no recommendation or even rule to make text columns that wide. Generally, narrower columns are easier to read (with some limit too, ofc, having only one word per line wouldn't help readability).
To me, the original looked better.
-
Nico Huber (Code Review)