Attention is currently required from: Dhiren Serai.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67331 )
Change subject: fix malloc garbage values issue ......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67331/comment/e16c2e6d_ccb0a8c5 PS2, Line 13: to zero as default so it will not be uninitialized/garbage. I have trouble to understand if this is silencing a false-positive, fixing a bug or covering one up. What is the actual issue? Having garbage values in memory is only a problem if we read/process them.
Would the zeros be read somewhere? If so is zero a reasonable value? is there another issue maybe, that data is read that shouldn't be?
-
Nico Huber (Code Review)