Attention is currently required from: Dhiren Serai.
View Change
1 comment:
Commit Message:
Patch Set #2, Line 13: to zero as default so it will not be uninitialized/garbage.
I have trouble to understand if this is silencing a false-positive,
fixing a bug or covering one up. What is the actual issue? Having
garbage values in memory is only a problem if we read/process them.
Would the zeros be read somewhere? If so is zero a reasonable value?
is there another issue maybe, that data is read that shouldn't be?
To view, visit change 67331. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id3390a40033408d827d89c3af4cd7b799e254271
Gerrit-Change-Number: 67331
Gerrit-PatchSet: 2
Gerrit-Owner: Dhiren Serai <dhirensr@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anastasia Klimchuk <aklm@chromium.org>
Gerrit-CC: Felix Singer <felixsinger@posteo.net>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Thomas Heijligen <src@posteo.de>
Gerrit-Attention: Dhiren Serai <dhirensr@gmail.com>
Gerrit-Comment-Date: Mon, 24 Oct 2022 08:26:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment