Attention is currently required from: Aarya, Nikolai Artemiev, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/flashrom/+/84102?usp=email )
Change subject: Complete and fix progress feature implementation for all operations ......................................................................
Patch Set 11:
(3 comments)
File cli_output.c:
https://review.coreboot.org/c/flashrom/+/84102/comment/928dba0e_9e73b8b1?usp... : PS9, Line 27: indicated
nit: `to indicate`?
Done
https://review.coreboot.org/c/flashrom/+/84102/comment/51f97876_f4a24410?usp... : PS9, Line 33: enum last_printed_before_progress progress_separator
nit: `enum line_state line_state`? […]
Done
https://review.coreboot.org/c/flashrom/+/84102/comment/8d54f950_48c9b89e?usp... : PS9, Line 164: progress_separator = (fmt[strlen(fmt) - 1] == '\n' ? NEWLINE : MIDLINE);
This and the analogous line below will have out of bounds access if the format string is empty.
Oh yes, I haven't thought about it! There are probably many ways to fix that, I picked one way, let me know if you disagree.