Attention is currently required from: Aarya, Nikolai Artemiev, Sergii Dmytruk.

View Change

3 comments:

• File cli_output.c:

  • Patch Set #9, Line 27: indicated

    nit: `to indicate`?

    Done

  • Patch Set #9, Line 33: enum last_printed_before_progress progress_separator

    nit: `enum line_state line_state`? […]

    Done

  • Patch Set #9, Line 164: progress_separator = (fmt[strlen(fmt) - 1] == '\n' ? NEWLINE : MIDLINE);

    This and the analogous line below will have out of bounds access if the format string is empty.

    Oh yes, I haven't thought about it! There are probably many ways to fix that, I picked one way, let me know if you disagree.

To view, visit change 84102. To unsubscribe, or for help writing mail filters, visit settings.