[S] Change in flashrom[master]: include/flash.h: Turn defines into a flashrom error enum type

[Angel Pons (Code Review)]

Attention is currently required from: Edward O'Callaghan.

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68778 )

Change subject: include/flash.h: Turn defines into a flashrom error enum type
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

File include/flash.h:

https://review.coreboot.org/c/flashrom/+/68778/comment/c706a13f_42658d53 
PS1, Line 439: typedef enum {
Do we need the typedef, or could we use `enum flashrom_error`?

https://flashrom.org/Development_Guidelines#Coding_style points to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu... which states why typedefs shouldn't be used in most cases. In flashrom, we use typedefs for *some* function pointers, possibly for the sake of brevity.