Attention is currently required from: Edward O'Callaghan.

Patch set 1:Code-Review +1

View Change

1 comment:

• File include/flash.h:

  • Patch Set #1, Line 439: typedef enum {

    Do we need the typedef, or could we use `enum flashrom_error`?

    https://flashrom.org/Development_Guidelines#Coding_style points to https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst#n359 which states why typedefs shouldn't be used in most cases. In flashrom, we use typedefs for *some* function pointers, possibly for the sake of brevity.

To view, visit change 68778. To unsubscribe, or for help writing mail filters, visit settings.