Attention is currently required from: Anastasia Klimchuk.
Funkeleinhorn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81428?usp=email )
Change subject: serprog: Add SPI Mode and CS Mode commands ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Nice to meet you, and thank you for the patch! […]
Heyy nice to meet you too.
Sorry that you missed the discussion on IRC. I didn't know about the Discord and that the main discussions are there now.
1 Yess so far I only add the commands to the documentation/the spec but do not implement them in flashrom. This is because as I understand flashrom is targeted at reading/writing flash chips and the current commands suffice for that. But we could add additional SPI modes to the 0x17 SPI mode command which could be useful for the current flashrom implementation. For example we could allow programmers to support dual or quad SPI which could speed up read/writes on supported chips and programmers. I hope that makes some things more clear. What do you mean with add implementation to upstream serprog? Are you talking about adding support for flashing AVR microcontrollers to flashrom? I so far considered this out of scope for the project as it would require some bigger changes like also implementing the AVR ISP protocol.
2 It would be cool to have some group to coordinate the serprog protocol spec across projects using it but as I know there is no central authority or working group for the serprog protocol so far. This is why I would consider flashrom and its fork flashprog the authority over the serprog spec (serprog-protocol.txt) as the protocol evolved there. The numbers 0x17 and 0x18 where chosen because they are the lowest unassigned ones and I tought it would be nice to have no gaps in the specified commands. But we could choose them arbitarily from the unassigned range.
3 Yes sure I am up for reviewing changes to the serprog documentation.
-
Funkeleinhorn (Code Review)