Attention is currently required from: Funkeleinhorn, Urja Rannikko.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81428?usp=email )
Change subject: serprog: Add SPI Mode and CS Mode commands ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Patchset:
PS1: Urja, good day, I thought maybe you are still around and have some interest to review the update to serprog protocol? Thank you!
PS1: Thank you for detailed explanation, I think I understand now.
What do you mean with add implementation to upstream serprog?
I was wondering, but you answered just above these words:
so far I only add the commands to the documentation/the spec but do not implement them in flashrom.
I wasn't looking into details, but I just quickly looked into the code of avrgirl serprog-programmer and noticed that S_SPI_MODE and S_CS_MODE are handled there, this is where my question came from.
I agree supporting dual or quad SPI is a good idea. But I think this patch can go ahead, doesn't have to wait.
Yes sure I am up for reviewing changes to the serprog documentation.
Great. I really appreciate it!
-
Anastasia Klimchuk (Code Review)