Attention is currently required from: Richard Hughes, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Patrick Rudolph. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49643 )
Change subject: libflashrom: Return progress state to the library user ......................................................................
Patch Set 18:
(6 comments)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/49643/comment/6849c788_b23f01ad PS17, Line 78: struct flashrom_update_progress { : enum flashrom_progress_stage stage; : size_t current; : size_t total; : void *user_data; : };
should all this internal state be exposed to the user?
That is how the user callback can make sense on where the progress is sitting at (i.e., current/total for stage)
https://review.coreboot.org/c/flashrom/+/49643/comment/8b3e63cf_00e4b95d PS17, Line 84: struct flashrom_flashctx;
duplicates another forward declaration on line 205.
Done
https://review.coreboot.org/c/flashrom/+/49643/comment/a59672fa_e804352e PS17, Line 85: struct flashrom_update_progress *progress_state
X: I guess just document this signature better so it is clear why the passed copy is used and not th […]
Done
https://review.coreboot.org/c/flashrom/+/49643/comment/41408e9a_e3120fa9 PS17, Line 85: struct flashrom_update_progress *progress_state
X: I guess just document this signature better so it is clear why the passed copy is used and not th […]
Done
https://review.coreboot.org/c/flashrom/+/49643/comment/5a03cc1a_54a8ebfe PS17, Line 97: update
`s/update/set||init/` the func name made me dizzy.
Done
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/49643/comment/456e6141_1a6703f8 PS17, Line 84: flashctx->progress_callback(flashctx, flashctx->progress_state);
Y: Because in theory this could become `flashctx->progress_callback(flashctx);` given the above in X […]
Done
-
Daniel Campello (Code Review)