Attention is currently required from: Richard Hughes, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Patrick Rudolph.

View Change

6 comments:

• File include/libflashrom.h:

  • Patch Set #17, Line 78:

    struct flashrom_update_progress {
    	enum flashrom_progress_stage stage;
    	size_t current;
    	size_t total;
    	void *user_data;
    };
    

    should all this internal state be exposed to the user?

    That is how the user callback can make sense on where the progress is sitting at (i.e., current/total for stage)

  • Patch Set #17, Line 84: struct flashrom_flashctx;

    duplicates another forward declaration on line 205.

    Done

  • Patch Set #17, Line 85: struct flashrom_update_progress *progress_state

    X: I guess just document this signature better so it is clear why the passed copy is used and not th […]

    Done

  • Patch Set #17, Line 85: struct flashrom_update_progress *progress_state

    X: I guess just document this signature better so it is clear why the passed copy is used and not th […]

    Done

  • Patch Set #17, Line 97: update

    `s/update/set||init/` the func name made me dizzy.

    Done

• File libflashrom.c:

  • Patch Set #17, Line 84: flashctx->progress_callback(flashctx, flashctx->progress_state);

    Y: Because in theory this could become `flashctx->progress_callback(flashctx);` given the above in X […]

    Done

To view, visit change 49643. To unsubscribe, or for help writing mail filters, visit settings.