Attention is currently required from: Aarya, Nikolai Artemiev, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change by Sergii Dmytruk. ( https://review.coreboot.org/c/flashrom/+/84102?usp=email )
Change subject: Complete and fix progress feature implementation for all operations ......................................................................
Patch Set 4:
(3 comments)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/84102/comment/8c2a661d_e6a7594e?usp... : PS1, Line 58: unsigned long long delay_ns;
I think insufficient range was my first guess, before I noticed `(1000000 * 8) / freq` below. […]
Changes for dummyflasher are in a separate commit here CB:84423
File linux_mtd.c:
https://review.coreboot.org/c/flashrom/+/84102/comment/a4bca64a_59e2b315?usp... : PS1, Line 298: update_progress(flash, FLASHROM_PROGRESS_ERASE, u + data->erasesize, len);
It's for erasing which I think is handled uniformly in `erasure_layout.c`.
Done
File spi.c:
https://review.coreboot.org/c/flashrom/+/84102/comment/2d0d86d0_8eb3dcf6?usp... : PS1, Line 118: update_progress(flash, FLASHROM_PROGRESS_READ, start - start_address + to_read, end_address);
`flash->mst->spi. […]
Thanks I understand now. I changed the existing test to call `default_spi_read` because progress is updated on that level.