Attention is currently required from: Aarya, Nikolai Artemiev, Sergii Dmytruk.

View Change

3 comments:

• File dummyflasher.c:

  • Patch Set #1, Line 58: unsigned long long delay_ns;

    I think insufficient range was my first guess, before I noticed `(1000000 * 8) / freq` below. […]

    Changes for dummyflasher are in a separate commit here CB:84423

• File linux_mtd.c:

  • Patch Set #1, Line 298: update_progress(flash, FLASHROM_PROGRESS_ERASE, u + data->erasesize, len);

    It's for erasing which I think is handled uniformly in `erasure_layout.c`.

    Done

• File spi.c:

  • Patch Set #1, Line 118: update_progress(flash, FLASHROM_PROGRESS_READ, start - start_address + to_read, end_address);

    `flash->mst->spi. […]

    Thanks I understand now. I changed the existing test to call `default_spi_read` because progress is updated on that level.

To view, visit change 84102. To unsubscribe, or for help writing mail filters, visit settings.