Nico Huber has posted comments on this change. ( https://review.coreboot.org/25047 )
Change subject: Add support for Atmel / Adesto AT25SF041 SPI flash chip ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/25047/7/flashchips.c File flashchips.c:
https://review.coreboot.org/#/c/25047/7/flashchips.c@2178 PS7, Line 2178: Copy of AT25DF041A not any more
https://review.coreboot.org/#/c/25047/7/flashchips.c@2209 PS7, Line 2209: .printlock = spi_prettyprint_status_register_at25df, : .unlock = spi_disable_blockprotect_at2x_global_unprotect, These do not match the chip's status register at all. Please use the generic implementations (spi_prettyprint_status_register_plain(), spi_disable_blockprotect()) unless you want to implement an at25sf variant.