View Change
2 comments:
File flashchips.c:
Patch Set #7, Line 2178: Copy of AT25DF041A
not any more
Patch Set #7, Line 2209:
.printlock = spi_prettyprint_status_register_at25df,
.unlock = spi_disable_blockprotect_at2x_global_unprotect,
These do not match the chip's status register at all. Please use
the generic implementations (spi_prettyprint_status_register_plain(),
spi_disable_blockprotect()) unless you want to implement an at25sf
variant.
To view, visit change 25047. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0be930ff2258300508398e12fbe5abe10400fea2
Gerrit-Change-Number: 25047
Gerrit-PatchSet: 7
Gerrit-Owner: Julian von Mendel <git@jinvent.de>
Gerrit-Reviewer: Julian von Mendel <git@jinvent.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: David Hendricks <david.hendricks@gmail.com>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-Comment-Date: Sat, 10 Mar 2018 16:53:37 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No