Change in flashrom[master]: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c ......................................................................
Patch Set 17:
(3 comments)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/4e04c3b5_ae95952b PS16, Line 111: return 0x00; /* ENE_KB932.ec_is_running mask */
This else path should have braces, too. The rule is to have them on […]
Done
File tests/io_mock.h:
https://review.coreboot.org/c/flashrom/+/51487/comment/1ed4305a_a5986e6b PS13, Line 37: unsigned char
I don't mind. `state` works too 😊 […]
Of course, I agree. Very good to have all the same types everywhere. (stdint.h is still needed for __wrap_sio_read and __wrap_sio_write)
File tests/tests.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/6100e760_69acfa65 PS16, Line 95: */
I'm not a fan of such comments. It's too obvious and such boilerplate […]
Done (removed those comments).
-
Anastasia Klimchuk (Code Review)