Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.

View Change

3 comments:

• File tests/init_shutdown.c:

  • Patch Set #16, Line 111: return 0x00; /* ENE_KB932.ec_is_running mask */

    This else path should have braces, too. The rule is to have them on […]

    Done

• File tests/io_mock.h:

  • Patch Set #13, Line 37: unsigned char

    I don't mind. `state` works too 😊 […]

    Of course, I agree. Very good to have all the same types everywhere.
    (stdint.h is still needed for __wrap_sio_read and __wrap_sio_write)

• File tests/tests.c:

  • Patch Set #16, Line 95: */

    I'm not a fan of such comments. It's too obvious and such boilerplate […]

    Done (removed those comments).

To view, visit change 51487. To unsubscribe, or for help writing mail filters, visit settings.