Attention is currently required from: Antonio Vázquez Blanco.
Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/85072?usp=email )
Change subject: Rename cli_classic.h to a more adequate cli_getop.h ......................................................................
Patch Set 1:
(2 comments)
File cli_getopt.c:
https://review.coreboot.org/c/flashrom/+/85072/comment/7f31a2e3_e17b61c3?usp... : PS1, Line 28: #include "cli_getopt.h" I noticed you put this line on the top, why? Usually the style we have is: first come includes in <> and then in ""
Given that cli_getopt.h is replacement for cli_classic.h, probably keep it on the same line.
https://review.coreboot.org/c/flashrom/+/85072/comment/c23f746e_137f0513?usp... : PS1, Line 35: // msg_gerr I noticed you are adding this comments for includes of flash.h, and while the comment is true, but I don't think we need it. There are so many includes, and we won't be commenting on each one anyway.
-
Anastasia Klimchuk (Code Review)