Attention is currently required from: Antonio Vázquez Blanco.

View Change

2 comments:

• File cli_getopt.c:

  • Patch Set #1, Line 28: #include "cli_getopt.h"

    I noticed you put this line on the top, why? Usually the style we have is: first come includes in <> and then in ""

    Given that cli_getopt.h is replacement for cli_classic.h, probably keep it on the same line.

  • Patch Set #1, Line 35: // msg_gerr

    I noticed you are adding this comments for includes of flash.h, and while the comment is true, but I don't think we need it. There are so many includes, and we won't be commenting on each one anyway.

To view, visit change 85072. To unsubscribe, or for help writing mail filters, visit settings.